Skip to content

Improve experimental/debug.h with many helper macros#24

Merged
pixelherodev merged 4 commits into
KnightOS:masterfrom
aviallon:patch-debug-improvement
Jun 10, 2020
Merged

Improve experimental/debug.h with many helper macros#24
pixelherodev merged 4 commits into
KnightOS:masterfrom
aviallon:patch-debug-improvement

Conversation

@aviallon
Copy link
Copy Markdown
Member

@aviallon aviallon commented Jun 6, 2020

This is very useful for displaying error/debug messages to the developper.
Has to be merged after #23 for full compatibility.

This is very useful for displaying error/debug messages to the developper.
Copy link
Copy Markdown

@pixelherodev pixelherodev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty good overall, though I'd like a few changes as noted.

I really appreciate you doing this, it motivates me to work on this more as well :)

Comment thread include/experimental/debug.h Outdated
Comment thread include/experimental/debug.h Outdated
Copy link
Copy Markdown

@pixelherodev pixelherodev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good now, I think.

Comment thread include/experimental/debug.h
Comment thread include/experimental/debug.h
@pixelherodev pixelherodev merged commit 07b5cac into KnightOS:master Jun 10, 2020
@aviallon aviallon deleted the patch-debug-improvement branch June 10, 2020 22:32
aviallon added a commit to aviallon/libc that referenced this pull request Jun 14, 2020
* Improve experimental/debug.h with many helper macros

This is very useful for displaying error/debug messages to the developper.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants